Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for Kafka Tests following the Proactor/Reactor split #3447

Merged
merged 29 commits into from
Jan 15, 2025
Merged

Fixes for Kafka Tests following the Proactor/Reactor split #3447

merged 29 commits into from
Jan 15, 2025

Conversation

iancooper
Copy link
Member

No description provided.

@iancooper iancooper self-assigned this Dec 31, 2024
@iancooper iancooper added Bug v10 Allocal to a v10 release .NET Pull requests that update .net code labels Dec 31, 2024
codescene-delta-analysis[bot]
codescene-delta-analysis bot approved these changes Dec 31, 2024
View reviewed changes
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.00 (9.84 -> 9.84)

View detailed results in CodeScene

codescene-delta-analysis[bot]
codescene-delta-analysis bot approved these changes Dec 31, 2024
View reviewed changes
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.00 (9.84 -> 9.84)

View detailed results in CodeScene

codescene-delta-analysis[bot]
codescene-delta-analysis bot approved these changes Dec 31, 2024
View reviewed changes
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.00 (9.84 -> 9.84)

View detailed results in CodeScene

codescene-delta-analysis[bot]
codescene-delta-analysis bot approved these changes Jan 2, 2025
View reviewed changes
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.00 (9.84 -> 9.84)

View detailed results in CodeScene

codescene-delta-analysis[bot]
codescene-delta-analysis bot approved these changes Jan 6, 2025
View reviewed changes
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.00 (9.74 -> 9.74)

View detailed results in CodeScene

codescene-delta-analysis[bot]
codescene-delta-analysis bot approved these changes Jan 6, 2025
View reviewed changes
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.00 (9.74 -> 9.74)

View detailed results in CodeScene

codescene-delta-analysis[bot]
codescene-delta-analysis bot approved these changes Jan 6, 2025
View reviewed changes
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.00 (9.72 -> 9.72)

View detailed results in CodeScene

codescene-delta-analysis[bot]
codescene-delta-analysis bot approved these changes Jan 8, 2025
View reviewed changes
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.00 (9.73 -> 9.72)

View detailed results in CodeScene

codescene-delta-analysis[bot]
codescene-delta-analysis bot approved these changes Jan 8, 2025
View reviewed changes
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.01 (9.04 -> 9.03)

View detailed results in CodeScene

codescene-delta-analysis[bot]
codescene-delta-analysis bot approved these changes Jan 8, 2025
View reviewed changes
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.01 (9.04 -> 9.03)

View detailed results in CodeScene

codescene-delta-analysis[bot]
codescene-delta-analysis bot approved these changes Jan 8, 2025
View reviewed changes
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.01 (9.04 -> 9.03)

View detailed results in CodeScene

@iancooper
fix: try to make more reliable, changes to receive. many proactor tes…
47fe38a 
…ts can only run locally, due to timing issues
codescene-delta-analysis[bot]
codescene-delta-analysis bot reviewed Jan 10, 2025
View reviewed changes
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.24 (9.04 -> 8.79)

  • Declining Code Health: 1 findings(s) 🚩

  • Affected Hotspots: 1 files(s) 🔥

View detailed results in CodeScene

src/Paramore.Brighter.MessagingGateway.Kafka/KafkaMessageConsumer.cs
@@ -315,9 +353,25 @@ public void Purge()
/// in production code
/// </remarks>
/// <param name="cancellationToken"></param>
public Task PurgeAsync(CancellationToken cancellationToken = default(CancellationToken))
public async Task PurgeAsync(CancellationToken cancellationToken = default(CancellationToken))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ New issue: Code Duplication
The module contains 4 functions with similar structure: CommitAllOffsets,CommitOffsets,PurgeAsync,ReceiveAsync

Suppress

codescene-delta-analysis[bot]
codescene-delta-analysis bot reviewed Jan 15, 2025
View reviewed changes
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.24 (9.04 -> 8.79)

  • Declining Code Health: 1 findings(s) 🚩

  • Affected Hotspots: 1 files(s) 🔥

View detailed results in CodeScene

@iancooper
chore: move tests to fragile that don't execute well in CI - many won…
779ded8 
…'t run locally if not in debug, but better to note these over never running
codescene-delta-analysis[bot]
codescene-delta-analysis bot reviewed Jan 15, 2025
View reviewed changes
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.24 (9.04 -> 8.79)

  • Declining Code Health: 1 findings(s) 🚩

  • Affected Hotspots: 1 files(s) 🔥

View detailed results in CodeScene

codescene-delta-analysis[bot]
codescene-delta-analysis bot reviewed Jan 15, 2025
View reviewed changes
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.24 (9.04 -> 8.79)

  • Declining Code Health: 1 findings(s) 🚩

  • Affected Hotspots: 1 files(s) 🔥

View detailed results in CodeScene

codescene-delta-analysis[bot]
codescene-delta-analysis bot reviewed Jan 15, 2025
View reviewed changes
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.24 (9.04 -> 8.79)

  • Declining Code Health: 1 findings(s) 🚩

  • Affected Hotspots: 1 files(s) 🔥

View detailed results in CodeScene

codescene-delta-analysis[bot]
codescene-delta-analysis bot reviewed Jan 15, 2025
View reviewed changes
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.24 (9.04 -> 8.79)

  • Declining Code Health: 1 findings(s) 🚩

  • Affected Hotspots: 1 files(s) 🔥

View detailed results in CodeScene

codescene-delta-analysis[bot]
codescene-delta-analysis bot reviewed Jan 15, 2025
View reviewed changes
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.24 (9.04 -> 8.79)

  • Declining Code Health: 1 findings(s) 🚩

  • Affected Hotspots: 1 files(s) 🔥

View detailed results in CodeScene

@iancooper iancooper marked this pull request as ready for review January 15, 2025 18:56
codescene-delta-analysis[bot]
codescene-delta-analysis bot reviewed Jan 15, 2025
View reviewed changes
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.24 (9.04 -> 8.79)

  • Declining Code Health: 1 findings(s) 🚩

  • Affected Hotspots: 1 files(s) 🔥

View detailed results in CodeScene

@iancooper
Copy link
Member Author

Likely to be a straight check in from PR as it is fixing broken tests

@iancooper iancooper merged commit d1484fe into master Jan 15, 2025
14 of 20 checks passed
@iancooper iancooper deleted the kafka_fixes branch January 15, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codescene-delta-analysis codescene-delta-analysis[bot] codescene-delta-analysis[bot] approved these changes

@holytshirt holytshirt Awaiting requested review from holytshirt holytshirt is a code owner

@DevJonny DevJonny Awaiting requested review from DevJonny DevJonny is a code owner

@preardon preardon Awaiting requested review from preardon preardon is a code owner

Assignees

@iancooper iancooper

Labels
2 - In Progress Bug .NET Pull requests that update .net code v10 Allocal to a v10 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iancooper